FIREFLY-2112: Add ESLint workflow and initial config - #2028
Merged
Merged
Conversation
aventura121
changed the title
aventura121
marked this pull request as ready for review
September 29, 2026 21:16
loitly
requested changes
Sep 30, 2026
loitly
left a comment
loitly
left a comment
Contributor
There was a problem hiding this comment.
This looks great. I like it. I just have a couple of requests.
Could you do the same thing you did for jsTest and have the workflow run the task through Docker?
Also, I think this should be another job in the test.yml workflow you created. That way, each PR has a single workflow with separate job results for each check, rather than multiple workflows.
loitly
approved these changes
Oct 1, 2026
loitly
left a comment
loitly
left a comment
Contributor
There was a problem hiding this comment.
Changes look great. Thank you.
aventura121
force-pushed
the
FIREFLY-2112-add-eslint-pr-workflow
branch
from
October 1, 2026 15:27
0e5ab0b to
79c7bc9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-2112: "Add ESLint job to PR pipeline for Dev Branch"
Description
This adds the ESLint configuration and workflow. It is not blocking.
Testing
This pull request is proof that the workflow works as intended.