Release 3.0.0: require netbox-custom-objects >= 0.7.0, drop combined tab - #21
Merged
Merged
Conversation
netbox-custom-objects 0.7.0 ships the combined "Custom Objects" tab itself (related_tabs/, same view name and weight as ours) and a templatetag library named custom_object_tab_tags, colliding with ours. Remove the combined tab, the customobject.html template override, the template_override module and the templatetags package; keep only per-Custom-Object-Type (typed) tabs. - PluginConfig.ready(): probe netbox_custom_objects.related_tabs.registry and raise ImproperlyConfigured when missing; warn on leftover combined_* settings; default_settings reduced to typed_models / typed_weight. - CO-page typed tab routes now go through a per-request slug dispatcher that resolves the host Custom Object Type and dispatches to the view registered for exactly that model. Fixes wrong host object and never- active tab when one type references several host types; replaces the 2.6.0 (label, weight) comparison workaround. - Fold views/_co_common.py into views/typed.py. - Tests: drop combined/templatetag suites, add plugin-config gate and dispatcher tests. - README, CHANGELOG, CLAUDE.md updated; TODO.md (combined backlog) removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
netbox-custom-objects 0.7.0 ships the combined "Custom Objects" tab natively and a templatetag library named
custom_object_tab_tags, colliding with ours. 3.0.0 keeps only the per-Custom-Object-Type tabs.Removed
combined_models/combined_label/combined_weight, template override +customobject.htmlcopy,custom_object_tab_tagstemplatetags,TODO.md.Changed
ready()probesnetbox_custom_objects.related_tabs.registry, raisesImproperlyConfiguredotherwise; leftovercombined_*keys log a warning.Fixed
Verification
pytest tests/(37 passed)manage.py checkclean.