fix: plan tool argument resilience and diagnostic rejections - #256
Merged
Merged
Conversation
The plan tool rejected malformed calls with uninformative errors (silently dropped keys reported only as 'got 0'), forcing multiple blind retries. Execute now diagnoses the envelope before the typed switch: rejections name the received keys and expected shape; missing step ids are auto-assigned (collision-safe against existing plan steps); bare string step entries coerce to titles; a single wrapper object carrying steps is unwrapped with an inference note. Ambiguous two-array input stays a hard error. Fail-closed validation and state atomicity unchanged.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
odek | afcc1d6 | Commit Preview URL Branch Preview URL |
Sep 19 2026, 02:32 PM |
jkyberneees
force-pushed
the
fix/plan-tool-arg-resilience
branch
from
September 19, 2026 14:31
71078c2 to
032f185
Compare
…GO-2026-4961) govulncheck flagged three webp/vp8l vulnerabilities reachable through vision_tool.go image.DecodeConfig, failing CI on main. v0.45.0 is the newest version compatible with the repo's go 1.25 directive (v0.46.0 requires go 1.26).
jkyberneees
force-pushed
the
fix/plan-tool-arg-resilience
branch
from
September 19, 2026 14:31
032f185 to
afcc1d6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The plan tool rejected malformed calls with uninformative errors (silently dropped keys reported only as
got 0), forcing multiple blind retries.PlanStore.Executenow diagnoses the envelope before the typed switch:{title}with auto idsFail-closed validation and state atomicity unchanged.
Verification
internal/loop/plan_args_resilience_test.go)go test ./internal/loop/ -count=1ok;go test -race -run TestPlanok;go vetclean