Skip to content

[Common,PWGCF,PWGDQ,PWGEM,PWGJE,PWGLF] Fix includes - #18113

Merged
vkucera merged 1 commit into
AliceO2Group:masterfrom
vkucera:iwyu
Sep 30, 2026
Merged

[Common,PWGCF,PWGDQ,PWGEM,PWGJE,PWGLF] Fix includes#18113
vkucera merged 1 commit into
AliceO2Group:masterfrom
vkucera:iwyu

Conversation

@vkucera

@vkucera vkucera commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot changed the title Fix includes [Common,PWGCF,PWGDQ,PWGEM,PWGJE,PWGLF] Fix includes Sep 29, 2026
@github-actions

github-actions Bot commented Sep 29, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 298 warnings, 🔕 36 disabled

@vkucera
vkucera marked this pull request as ready for review September 29, 2026 23:55
@alibuild

alibuild commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 5ee4b70 at 2026-09-30 03:28:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 17 errors and 440 warnings.'
Found 17 errors and 440 warnings.
++ [[ 17 -gt 0 ]]
++ cat /sw/BUILD/aed54feacfc4e5f742d8985105ab703f003d0c44/O2Physics-code-check/errors.txt
PWGCF/Femto3D/Tasks/multEstimator.cxx:325:5: error: Value stored to 'cadidates_counter' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:591:13: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGCF/TwoParticleCorrelations/Tasks/diHadronCor.cxx:694:13: error: Variable 'rad' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:69:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:70:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:71:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:72:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:73:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:74:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:75:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:76:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:77:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGEM/PhotonMeson/TableProducer/skimmerPrimaryElectronFromDalitzEE.h:78:1: error: using declarations in the global namespace in headers are prohibited [google-global-names-in-headers,-warnings-as-errors]
PWGLF/TableProducer/Common/zdcvector.cxx:452:9: error: Value stored to 'qxZDCA' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGLF/TableProducer/Common/zdcvector.cxx:453:9: error: Value stored to 'qxZDCC' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGLF/TableProducer/Common/zdcvector.cxx:454:9: error: Value stored to 'qyZDCA' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGLF/TableProducer/Common/zdcvector.cxx:455:9: error: Value stored to 'qyZDCC' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
++ [[ 440 -gt 0 ]]
++ cat /sw/BUILD/aed54feacfc4e5f742d8985105ab703f003d0c44/O2Physics-code-check/warnings.txt
PWGCF/Femto3D/Tasks/multEstimator.cxx:60:8: warning: constructor does not initialize these fields: ccdb [cppcoreguidelines-pro-type-member-init]
PWGCF/Femto3D/Tasks/multEstimator.cxx:83:41: warning: declaration uses identifier '_IRcut', which is a reserved identifier [bugprone-reserved-identifier]
PWGCF/Femto3D/Tasks/multEstimator.cxx:84:37: warning: declaration uses identifier '_OccupancyCut', which is a reserved identifier [bugprone-reserved-identifier]
PWGCF/Femto3D/Tasks/multEstimator.cxx:109:23: warning: declaration uses identifier '_PIDtrshld', which is a reserved identifier [bugprone-reserved-identifier]
PWGCF/Femto3D/Tasks/multEstimator.cxx:201:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:204:87: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:206:88: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:208:48: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:239:80: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:258:82: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:260:84: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:262:84: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:264:212: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:275:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:277:33: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:279:52: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:281:84: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:283:185: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:285:108: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:287:94: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:290:92: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:292:41: warning: statement should be inside braces [readability-braces-around-statements]
PWGCF/Femto3D/Tasks/multEstimator.cxx:294:90: warning: statement should be inside braces [readability-braces-around-statements]
[0 more errors; see full log]

Full log here.

@vkucera

vkucera commented Sep 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Trivial and compiled. Merging.

@vkucera
vkucera merged commit a54a5fd into AliceO2Group:master Sep 30, 2026
11 of 13 checks passed
@vkucera
vkucera deleted the iwyu branch September 30, 2026 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner
@nzardosh nzardosh Awaiting requested review from nzardosh nzardosh is a code owner
@fjonasALICE fjonasALICE Awaiting requested review from fjonasALICE fjonasALICE is a code owner
@jaimenorman jaimenorman Awaiting requested review from jaimenorman jaimenorman is a code owner
@mhemmer-cern mhemmer-cern Awaiting requested review from mhemmer-cern mhemmer-cern is a code owner
@omvazque omvazque Awaiting requested review from omvazque omvazque is a code owner
@mpuccio mpuccio Awaiting requested review from mpuccio mpuccio is a code owner
@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner
@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner
@romainschotter romainschotter Awaiting requested review from romainschotter romainschotter is a code owner
@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner
@dmallick2 dmallick2 Awaiting requested review from dmallick2 dmallick2 is a code owner
@smaff92 smaff92 Awaiting requested review from smaff92 smaff92 is a code owner
@prottayCMT prottayCMT Awaiting requested review from prottayCMT prottayCMT is a code owner
@gbencedi gbencedi Awaiting requested review from gbencedi gbencedi is a code owner
@abmodak abmodak Awaiting requested review from abmodak abmodak is a code owner
@dsekihat dsekihat Awaiting requested review from dsekihat dsekihat is a code owner
@jokonig jokonig Awaiting requested review from jokonig jokonig is a code owner
@hscheid hscheid Awaiting requested review from hscheid hscheid is a code owner
@amaringarcia amaringarcia Awaiting requested review from amaringarcia amaringarcia is a code owner
@reygers reygers Awaiting requested review from reygers reygers is a code owner
@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner
@mcoquet642 mcoquet642 Awaiting requested review from mcoquet642 mcoquet642 is a code owner
@XiaozhiBai XiaozhiBai Awaiting requested review from XiaozhiBai XiaozhiBai is a code owner
@mguilbau mguilbau Awaiting requested review from mguilbau mguilbau is a code owner
@jaelpark jaelpark Awaiting requested review from jaelpark jaelpark is a code owner
@wenyaCern wenyaCern Awaiting requested review from wenyaCern wenyaCern is a code owner
@victor-gonzalez victor-gonzalez Awaiting requested review from victor-gonzalez victor-gonzalez is a code owner
@dsarkaralice dsarkaralice Awaiting requested review from dsarkaralice dsarkaralice is a code owner
@lauraser lauraser Awaiting requested review from lauraser lauraser is a code owner
@glromane glromane Awaiting requested review from glromane glromane is a code owner
@sofiatomassini sofiatomassini Awaiting requested review from sofiatomassini sofiatomassini is a code owner
@dimihayl dimihayl Awaiting requested review from dimihayl dimihayl is a code owner
@wrzesaCERN wrzesaCERN Awaiting requested review from wrzesaCERN wrzesaCERN is a code owner
@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner
@ktf ktf Awaiting requested review from ktf ktf is a code owner
@ddobrigk ddobrigk Awaiting requested review from ddobrigk ddobrigk is a code owner

Assignees

No one assigned

Labels

common photon Photon and neutral meson PAG label pwgcf pwgdq pwgem pwgje pwglf

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vkucera @alibuild