Skip to content

[PWGCF] Fix cpplint errors - #18097

Open
vkucera wants to merge 2 commits into
AliceO2Group:masterfrom
vkucera:cpplint-safe-PWGCF
Open

vkucera wants to merge 2 commits into
AliceO2Group:masterfrom
vkucera:cpplint-safe-PWGCF

Conversation

@vkucera

@vkucera vkucera commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Fixes errors from the following categories:

  • readability/inheritance
  • readability/braces
  • readability/multiline_comment
  • whitespace/newline
  • whitespace/empty_if_body
  • build/include_what_you_use
  • build/header_guard

Fixes errors from the following categories:

- `readability/inheritance`
- `readability/braces`
- `readability/multiline_comment`
- `whitespace/newline`
- `whitespace/empty_if_body`
- `build/include_what_you_use`
- `build/header_guard`
@github-actions github-actions Bot added the pwgcf label Sep 29, 2026
@github-actions

github-actions Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 404 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Fix cpplint errors [PWGCF] Fix cpplint errors Sep 29, 2026
@vkucera
vkucera marked this pull request as ready for review September 29, 2026 12:02
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for a18bf34 at 2026-09-29 15:16:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 71 errors and 174 warnings.'
Found 71 errors and 174 warnings.
++ [[ 71 -gt 0 ]]
++ cat /sw/BUILD/ba6aeebbc3581456023668bda447557edc1c629d/O2Physics-code-check/errors.txt
PWGCF/Femto3D/Tasks/multEstimator.cxx:17:1: error: included header singletrackselector.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:29:1: error: included header MathConstants.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:30:1: error: included header Propagator.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:46:1: error: included header array is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:91:16: error: no header providing "int16_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:179:34: error: no header providing "Form" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:204:67: error: no header providing "o2::aod::evsel::kNoSameBunchPileup" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:206:68: error: no header providing "o2::aod::evsel::kIsGoodZvtxFT0vsPV" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:248:72: error: no header providing "o2::aod::pidits::ITSNSigmaPr" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:281:67: error: no header providing "o2::aod::evsel::kIsVertexITSTPC" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:283:91: error: no header providing "o2::aod::evsel::kIsVertexTOFmatched" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:283:163: error: no header providing "o2::aod::evsel::kIsVertexTRDmatched" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:285:80: error: no header providing "o2::aod::evsel::kNoCollInTimeRangeStandard" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:287:73: error: no header providing "o2::aod::evsel::kIsGoodITSLayersAll" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/Femto3D/Tasks/multEstimator.cxx:325:5: error: Value stored to 'cadidates_counter' is never read [clang-analyzer-deadcode.DeadStores,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:19:1: error: included header LFStrangenessTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:21:1: error: included header trackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:30:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:35:1: error: included header Track.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:37:1: error: included header Vector4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:38:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:63:3: error: no header providing "o2::framework::Produces" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:65:17: error: no member named 'FemtoWorldDebugParticles' in namespace 'o2::aod' [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:67:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:79:60: error: no header providing "kINT7" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:96:103: error: no header providing "o2::track::PID" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:98:48: error: no header providing "o2::framework::OutputObjHandlingPolicy" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:102:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:104:13: error: no header providing "o2::framework::InitContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:109:97: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kEqual" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:110:97: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kLowerLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:111:96: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kAbsUpperLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:117:104: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kUpperLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:29: error: no header providing "std::chrono::duration_cast" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:56: error: no header providing "std::chrono::milliseconds" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:83: error: no header providing "std::chrono::system_clock" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:139:31: error: no header providing "uint64_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:178:9: error: no matching function for call to object of type 'Produces<aod::FemtoWorldCollisions>' (aka 'Produces<Table<Hash<"FemtoWorldCollisions"_h>, Hash<"FEMTOWORLDCOLS/0"_h>, Hash<"AOD"_h>>>') [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:185:5: error: no matching function for call to object of type 'Produces<aod::FemtoWorldCollisions>' (aka 'Produces<Table<Hash<"FemtoWorldCollisions"_h>, Hash<"FEMTOWORLDCOLS/0"_h>, Hash<"AOD"_h>>>') [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:198:7: error: no matching function for call to object of type 'Produces<aod::FemtoWorldParticles>' (aka 'Produces<Table<Hash<"FemtoWorldParticles"_h>, Hash<"FEMTOWORLDPARTS/0"_h>, Hash<"AOD"_h>>>') [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:22:1: error: included header trackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:31:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

SwatiSaha-1997
SwatiSaha-1997 previously approved these changes Sep 30, 2026
@vkucera

vkucera commented Sep 30, 2026

Copy link
Copy Markdown
Collaborator Author

Ping

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for b494207 at 2026-09-30 20:05:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 56 errors and 143 warnings.'
Found 56 errors and 143 warnings.
++ [[ 56 -gt 0 ]]
++ cat /sw/BUILD/cdc2fa53be2ae331c90614ea0fb21970c144a9fd/O2Physics-code-check/errors.txt
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:19:1: error: included header LFStrangenessTables.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:21:1: error: included header trackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:30:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:35:1: error: included header Track.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:37:1: error: included header Vector4D.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:38:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:63:3: error: no header providing "o2::framework::Produces" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:65:17: error: no member named 'FemtoWorldDebugParticles' in namespace 'o2::aod' [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:67:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:79:60: error: no header providing "kINT7" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:96:103: error: no header providing "o2::track::PID" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:98:48: error: no header providing "o2::framework::OutputObjHandlingPolicy" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:102:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:104:13: error: no header providing "o2::framework::InitContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:109:97: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kEqual" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:110:97: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kLowerLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:111:96: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kAbsUpperLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:117:104: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kUpperLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:29: error: no header providing "std::chrono::duration_cast" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:56: error: no header providing "std::chrono::milliseconds" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:134:83: error: no header providing "std::chrono::system_clock" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:139:31: error: no header providing "uint64_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:178:9: error: no matching function for call to object of type 'Produces<aod::FemtoWorldCollisions>' (aka 'Produces<Table<Hash<"FemtoWorldCollisions"_h>, Hash<"FEMTOWORLDCOLS/0"_h>, Hash<"AOD"_h>>>') [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:185:5: error: no matching function for call to object of type 'Produces<aod::FemtoWorldCollisions>' (aka 'Produces<Table<Hash<"FemtoWorldCollisions"_h>, Hash<"FEMTOWORLDCOLS/0"_h>, Hash<"AOD"_h>>>') [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerReducedTask.cxx:198:7: error: no matching function for call to object of type 'Produces<aod::FemtoWorldParticles>' (aka 'Produces<Table<Hash<"FemtoWorldParticles"_h>, Hash<"FEMTOWORLDPARTS/0"_h>, Hash<"AOD"_h>>>') [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:22:1: error: included header trackUtilities.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:31:1: error: included header ASoAHelpers.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:36:1: error: included header Track.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:39:1: error: included header Vector4Dfwd.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:40:1: error: included header TMath.h is not used directly [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:73:8: error: no header providing "size_t" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:84:3: error: no header providing "o2::framework::Produces" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:86:17: error: no member named 'FemtoWorldDebugParticles' in namespace 'o2::aod' [clang-diagnostic-error]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:88:3: error: no header providing "o2::framework::Configurable" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:101:60: error: no header providing "kINT7" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:125:111: error: no header providing "o2::track::PID" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:140:48: error: no header providing "o2::framework::OutputObjHandlingPolicy" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:144:3: error: no header providing "o2::framework::Service" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:146:13: error: no header providing "o2::framework::InitContext" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:154:92: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kEqual" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:155:94: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kLowerLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
PWGCF/FemtoWorld/TableProducer/femtoWorldProducerTaskV0Only.cxx:156:106: error: no header providing "o2::analysis::femtoWorld::femtoWorldSelection::kUpperLimit" is directly included [misc-include-cleaner,-warnings-as-errors]
[0 more errors; see full log]

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants