Conversation
zhengqi-w
requested review from
HorstMa,
alibuild,
maciacco,
mario-krueger,
mpuccio,
omvazque and
skundu692
as code owners
September 22, 2026 17:23
|
O2 linter results: ❌ 0 errors, |
mario-krueger
approved these changes
Sep 22, 2026
mario-krueger
enabled auto-merge (squash)
September 22, 2026 18:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the pair-pion TPC QA histogram from
hPionTPCtohPairPionTPCand update its fill call. This avoids a name collision with the track-selection QA histogram in the same task, which can cause incorrect merging and a crash in the global analysis-file sink at end of stream.No changes to selections, pairing, configurables, or output-table schemas.
Validation: local targeted compilation/linking, O2 linter, cppcheck, clang-format, and git diff checks passed. A full Hyperloop rerun is still needed to confirm the runtime fix.