Skip to content

[PWGLF] Add doClosureTestPureMC Configurable in hStrangeCorrelation.cxx - #18008

Merged
romainschotter merged 1 commit into
AliceO2Group:masterfrom
kcui1:doClosureTestPureMC
Sep 22, 2026
Merged

romainschotter merged 1 commit into
AliceO2Group:masterfrom
kcui1:doClosureTestPureMC

Conversation

@kcui1

@kcui1 kcui1 commented Sep 22, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 15 warnings, 🔕 0 disabled

@github-actions github-actions Bot changed the title Add doClosureTestPureMC Configurable in hStrangeCorrelation.cxx [PWGLF] Add doClosureTestPureMC Configurable in hStrangeCorrelation.cxx Sep 22, 2026
@romainschotter
romainschotter enabled auto-merge (squash) September 22, 2026 12:09
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for cea94c7 at 2026-09-22 19:11:

## sw/BUILD/O2-latest/log
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260922-0000/daily-20260922-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:75:56
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260922-0000/daily-20260922-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:83:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260922-0000/daily-20260922-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:84:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260922-0000/daily-20260922-0000/Detectors/Upgrades/ALICE3/ECal/base/src/ECalBaseLinkDef.h:19:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260922-0000/daily-20260922-0000/Detectors/Upgrades/ALICE3/RICH/base/src/RICHBaseLinkDef.h:18:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260922-0000/daily-20260922-0000/Detectors/Upgrades/ALICE3/MID/base/src/MI3BaseLinkDef.h:18:47


## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 2 errors and 69 warnings.'
Found 2 errors and 69 warnings.
++ [[ 2 -gt 0 ]]
++ cat /sw/BUILD/484010ace0db9a49ba17419b10d50ef78468d7a3/O2Physics-code-check/errors.txt
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:869:5: error: Variable 'radius' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:1245:5: error: Variable 'r' with floating point type 'double' should not be used as a loop counter [clang-analyzer-security.FloatLoopCounter,-warnings-as-errors]
++ [[ 69 -gt 0 ]]
++ cat /sw/BUILD/484010ace0db9a49ba17419b10d50ef78468d7a3/O2Physics-code-check/warnings.txt
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:98:8: warning: constructor does not initialize these fields: ccdb, pdgDB [cppcoreguidelines-pro-type-member-init]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:1675:75: warning: use designated initializer list to initialize 'PairLossPairKey' [modernize-use-designated-initializers]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3306:9: warning: the 'empty' method should be used to check for emptiness instead of comparing to an empty object [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3491:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3733:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3770:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:3925:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4010:11: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4067:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4126:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4176:11: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4289:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4319:9: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4577:15: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4579:41: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4588:30: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4589:57: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4590:56: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4623:36: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4632:28: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4634:51: warning: use 'contains' to check for membership [readability-container-contains]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4707:15: warning: boolean expression can be simplified by DeMorgan's theorem [readability-simplify-boolean-expr]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4709:30: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4723:26: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4734:28: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4816:13: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4820:31: warning: the 'empty' method should be used to check for emptiness instead of 'size' [readability-container-size-empty]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4938:26: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
PWGLF/Tasks/Strangeness/hStrangeCorrelation.cxx:4939:30: warning: redundant explicit casting to the same type 'int64_t' (aka 'long') as the sub-expression, remove this casting [readability-redundant-casting]
[0 more errors; see full log]

Full log here.

@romainschotter
romainschotter merged commit 5591daa into AliceO2Group:master Sep 22, 2026
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants