[PWGHF] Add charm D-D-meson femtoscopy workflows - #17998
Draft
zhangbiao-phy wants to merge 27 commits into
Draft
zhangbiao-phy wants to merge 27 commits into
zhangbiao-phy wants to merge 27 commits into
Conversation
|
O2 linter results: ❌ 0 errors, |
github-actions
Bot
changed the title
Please consider the following formatting changes to AliceO2Group#17998
zhangbiao-phy
marked this pull request as ready for review
September 21, 2026 15:55
zhangbiao-phy
requested review from
NicoleBastid,
alibuild,
apalasciano,
deepathoms,
fcatalan92,
fcolamar,
fgrosa,
gluparel,
hahassan7,
jpxrk,
mfaggin,
mmazzilli,
singhra1994,
stefanopolitano,
vkucera and
xinyepeng
as code owners
September 21, 2026 15:55
zhangbiao-phy
changed the title
Collaborator
|
Error while checking build/O2Physics/o2 for 13a67f1 at 2026-09-21 18:09: Full log here. |
Please consider the following formatting changes to AliceO2Group#17998
vkucera
reviewed
Sep 21, 2026
vkucera
reviewed
Sep 21, 2026
vkucera
reviewed
Sep 21, 2026
vkucera
reviewed
Sep 21, 2026
vkucera
reviewed
Sep 21, 2026
vkucera
marked this pull request as draft
September 21, 2026 19:01
Collaborator
|
@zhangbiao-phy Please test your changes locally before you open a PR for review. |
Please consider the following formatting changes to AliceO2Group#17998
Collaborator
|
Something is wrong with your formatting. Please don't break the lines unnecessarily. |
Please consider the following formatting changes to AliceO2Group#17998
vkucera
reviewed
Sep 22, 2026
Comment on lines
+166
to
+173
| static_cast<bool>(doprocessD0D0), | ||
| static_cast<bool>(doprocessD0Dstar), | ||
| static_cast<bool>(doprocessD0D0Ml), | ||
| static_cast<bool>(doprocessD0DstarMl), | ||
| static_cast<bool>(doprocessD0D0WithFT0C), | ||
| static_cast<bool>(doprocessD0DstarWithFT0C), | ||
| static_cast<bool>(doprocessD0D0MlWithFT0C), | ||
| static_cast<bool>(doprocessD0DstarMlWithFT0C)}; |
Collaborator
There was a problem hiding this comment.
The casting should not be needed.
vkucera
reviewed
Sep 22, 2026
Comment on lines
+245
to
+246
| if ((hypothesis == 0 ? cand.isSelD0() : cand.isSelD0bar()) < | ||
| selectionFlagD0) { |
Collaborator
There was a problem hiding this comment.
You still have weird line breaks throughout the code.
vkucera
reviewed
Sep 22, 2026
Comment on lines
+78
to
+81
| Configurable<float> maxBkgD0{"maxBkgD0", 1.f, "Maximum D0 background score"}; | ||
| Configurable<float> minPromptD0{"minPromptD0", 0.f, "Minimum D0 prompt score"}; | ||
| Configurable<float> maxBkgDstar{"maxBkgDstar", 1.f, "Maximum Dstar background score"}; | ||
| Configurable<float> minPromptDstar{"minPromptDstar", 0.f, "Minimum Dstar prompt score"}; |
Collaborator
There was a problem hiding this comment.
Please follow the naming conventions.
vkucera
reviewed
Sep 22, 2026
Comment on lines
+139
to
+140
| colBinningMultMultPercentile = { | ||
| {mixingBinVztx, mixingBinMult, mixingBinMultPercentile}, true}; |
vkucera
reviewed
Sep 22, 2026
Comment on lines
+208
to
+209
| if (!std::isfinite(row.bdtBkg()) || !std::isfinite(row.bdtPrompt()) || | ||
| row.bdtBkg() < 0.f || row.bdtPrompt() < 0.f) { |
vkucera
reviewed
Sep 22, 2026
Comment on lines
+279
to
+280
| template <typename Policy, typename Collision> | ||
| int mixingBin(Policy const& policy, Collision col) |
Collaborator
There was a problem hiding this comment.
Please don't copy collisions.
vkucera
reviewed
Sep 22, 2026
Comment on lines
+474
to
+475
| return WorkflowSpec{ | ||
| adaptAnalysisTask<HfTaskCharmHadronsCharmFemtoDream>(cfgc)}; |
Collaborator
Author
There was a problem hiding this comment.
Ok, seems my format tool has something wrong
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a FemtoDream producer and analysis task for D0D0 and D0D*+ correlations, including like-sign and unlike-sign flavour combinations. Reuse the existing candidate and collision tables for offline pairing and event mixing. D0 candidates share the two-prong table, while D*+ candidates use the Dstar table. No dedicated D–D pair table is produced. And we only support do offline mixing for this analsyiss.
Tag @fgrosa for infos