Skip to content

[PWGCF] reduce ccdb calls and remove redundant histogram bookings in flowGenericFramework.cxx - #17993

Merged
EmilGorm merged 3 commits into
AliceO2Group:masterfrom
EmilGorm:ccdb_call_fix
Sep 21, 2026
Merged

EmilGorm merged 3 commits into
AliceO2Group:masterfrom
EmilGorm:ccdb_call_fix

Conversation

@EmilGorm

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions github-actions Bot added the pwgcf label Sep 21, 2026
@github-actions github-actions Bot changed the title reduce ccdb calls and remove redundant histogram bookings in flowGenericFramework.cxx [PWGCF] reduce ccdb calls and remove redundant histogram bookings in flowGenericFramework.cxx Sep 21, 2026
@github-actions

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@EmilGorm
EmilGorm marked this pull request as ready for review September 21, 2026 13:31
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for ee591c4 at 2026-09-21 17:08:

## sw/BUILD/O2Physics-code-check-latest/log
--
========== List of issues found ==========
++ echo 'Found 1 errors and 1 warnings.'
Found 1 errors and 1 warnings.
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/343e835ab2a25ec715aa32317f9a6ddd5aaee5e3/O2Physics-code-check/errors.txt
PWGCF/GenericFramework/Tasks/flowGenericFramework.cxx:1205:64: error: no header providing "std::distance" is directly included [misc-include-cleaner,-warnings-as-errors]
++ [[ 1 -gt 0 ]]
++ cat /sw/BUILD/343e835ab2a25ec715aa32317f9a6ddd5aaee5e3/O2Physics-code-check/warnings.txt
PWGCF/GenericFramework/Tasks/flowGenericFramework.cxx:942:11: warning: use auto when initializing with a cast to avoid duplicating the type name [modernize-use-auto]
++ [[ 1 -gt 0 ]]
++ exit 1
--

Full log here.

@EmilGorm
EmilGorm enabled auto-merge (squash) September 21, 2026 20:19

@alibuild alibuild left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @EmilGorm.

@EmilGorm
EmilGorm merged commit 298bd1d into AliceO2Group:master Sep 21, 2026
13 of 14 checks passed
@vkucera

vkucera commented Sep 22, 2026

Copy link
Copy Markdown
Collaborator

@EmilGorm Please remember to fix errors before merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

3 participants