Skip to content

[PWGCF] upgraded Lambda-Proton Balance Function Code - #17981

Merged
wenyaCern merged 9 commits into
AliceO2Group:masterfrom
Anoop1379:lambda-proton-bf-update-2
Sep 22, 2026
Merged

wenyaCern merged 9 commits into
AliceO2Group:masterfrom
Anoop1379:lambda-proton-bf-update-2

Conversation

@Anoop1379

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Sep 20, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 120 warnings, 🔕 0 disabled

@github-actions github-actions Bot added the pwgcf label Sep 20, 2026
@github-actions github-actions Bot changed the title upgraded Lambda-Proton Balance Function Code [PWGCF] upgraded Lambda-Proton Balance Function Code Sep 20, 2026
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 2342606 at 2026-09-20 13:40:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 29e565a at 2026-09-20 16:07:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for c1c8f77 at 2026-09-20 16:40:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for c3e0801 at 2026-09-20 17:00:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for c3e0801 at 2026-09-20 17:00:

## sw/BUILD/VecGeom-latest/log
CMake Error at /container/bits/sw/BUILD/4b902089e8ae3e1235b16cffffe5b41003a490dd/VecGeom/buildExternals/VecCore-0.8.0/build/external/stamp/VecCore-0.8.0-configure-RELWITHDEBINFO.cmake:49 (message):
ninja: build stopped: subcommand failed.
CMake Error at cmake/modules/BuiltinVecCore.cmake:36 (add_custom_command):
CMake Error at CMakeLists.txt:222 (find_package):

Full log here.

Removed unused fillRho2Pair function and related comments. Updated centering condition for filling centrality histograms.
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 61c722f at 2026-09-20 17:13:

No log files found

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 61c722f at 2026-09-20 17:18:

## sw/BUILD/GEANT4-latest/log
CMake Error at CMakeLists.txt:25 (cmake_minimum_required):

Full log here.

dsarkaralice
dsarkaralice previously approved these changes Sep 21, 2026
wenyaCern
wenyaCern previously approved these changes Sep 21, 2026
@wenyaCern
wenyaCern enabled auto-merge (squash) September 21, 2026 09:08
auto-merge was automatically disabled September 21, 2026 10:06

Head branch was pushed to by a user without write access

@Anoop1379
Anoop1379 dismissed stale reviews from wenyaCern and dsarkaralice via 2f6c111 September 21, 2026 10:06
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 2f6c111 at 2026-09-21 12:58:

No log files found

Full log here.

@wenyaCern
wenyaCern merged commit 54b18f9 into AliceO2Group:master Sep 22, 2026
15 checks passed
Comment on lines +1131 to +1135
int64_t gid;
float px, py, pz, E;
float eta, phi, y, pt;
int idxEta;
int idxY;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All members are uninitialised.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Vít,

Good catch. In the current implementation, all 'PartInfo' members are explicitly assigned in makeProtonInfo() before the object is returned and used. However, adding default member initialisers makes the struct safer against future changes.

I’ll add the default initialisers as suggested. Thanks for pointing this out.

Thanks

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your response.

@Anoop1379
Anoop1379 deleted the lambda-proton-bf-update-2 branch September 22, 2026 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

5 participants