Skip to content

[Common] pidTPCModule::createNetworkPrediction(): refactor and add NN version 5 - #17912

Open
lubynets wants to merge 13 commits into
AliceO2Group:masterfrom
lubynets:pid-tpc-module
Open

lubynets wants to merge 13 commits into
AliceO2Group:masterfrom
lubynets:pid-tpc-module

Conversation

@lubynets

Copy link
Copy Markdown
Contributor

1. Refactor pidTPCModule::createNetworkPrediction():

  • follow naming conventions;
  • replace magic numbers with named constants;
  • get rid of code repetition;
  • add const qualifier where appropriate
    This part does not have intention to change the observable behavior.

2. Introduce NN versions "dictionary"

  • add fatal error if NN name and number if input features do not match any entry in the dictionary.

3. Introduce NN version 5
which is similar to the version 4, but the azimuthal angle is recalculated to the value at TPC entrance.

@github-actions github-actions Bot changed the title pidTPCModule::createNetworkPrediction(): refactor and add NN version 5 [Common] pidTPCModule::createNetworkPrediction(): refactor and add NN version 5 Sep 14, 2026
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 39 warnings, 🔕 0 disabled

@lubynets

Copy link
Copy Markdown
Contributor Author

Dear codeowners, could you please review the PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant