Skip to content

[PWGHF] Adding D0/Lc analysis task - #17808

Draft
laszlogyulai wants to merge 25 commits into
AliceO2Group:masterfrom
laszlogyulai:master
Draft

laszlogyulai wants to merge 25 commits into
AliceO2Group:masterfrom
laszlogyulai:master

Conversation

@laszlogyulai

Copy link
Copy Markdown

Adding a new analysis task for calculating the D0/Lambda_c yield ratio as a function of flattenicity

@github-actions github-actions Bot added the pwghf PWG-HF label Sep 7, 2026
@github-actions github-actions Bot changed the title Adding D0/Lc analysis task [PWGHF] Adding D0/Lc analysis task Sep 7, 2026
@github-actions

github-actions Bot commented Sep 7, 2026

Copy link
Copy Markdown

O2 linter results: ❌ 0 errors, ⚠️ 0 warnings, 🔕 0 disabled

@laszlogyulai

Copy link
Copy Markdown
Author

Dear codeowners,

Is it possible to overcome the "magic number" errors in the O2 linter / O2 linter (pull_request_target) check? In my opinion it would unnecessarily complicate the existing code. You can see an example of such a solution in the PWGLF/Tasks/GlobalEventProperties/flattenicityPikp.cxx file (lines 1814-1908)

@vkucera

vkucera commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator

Dear codeowners,

Is it possible to overcome the "magic number" errors in the O2 linter / O2 linter (pull_request_target) check? In my opinion it would unnecessarily complicate the existing code. You can see an example of such a solution in the PWGLF/Tasks/GlobalEventProperties/flattenicityPikp.cxx file (lines 1814-1908)

The way to "overcome" it is to write it in a better way. From what I can see, you map some number to other numbers. So how about using a map or an array, for example?

laszlogyulai and others added 2 commits September 11, 2026 11:32
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
Co-authored-by: Vít Kučera <26327373+vkucera@users.noreply.github.com>
@laszlogyulai

Copy link
Copy Markdown
Author

Dear code owners,
Can you tell me if anything is needed from my side at this point?

You have not fixed the warnings.

Dear Vit,

From my side, I see that all checks are successful, and the only ones that are pending are awaiting a code owner approval.

image

@vkucera

vkucera commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Dear Vit,

From my side, I see that all checks are successful, and the only ones that are pending are awaiting a code owner approval.

Please look at the O2 linter result at the top.

Please consider the following formatting changes to AliceO2Group#17808
@laszlogyulai

Copy link
Copy Markdown
Author

Dear Vit,
From my side, I see that all checks are successful, and the only ones that are pending are awaiting a code owner approval.

Please look at the O2 linter result at the top.

Is everything fine now?

@vkucera

vkucera commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

Dear Vit,
From my side, I see that all checks are successful, and the only ones that are pending are awaiting a code owner approval.

Please look at the O2 linter result at the top.

Is everything fine now?

Looks good to me so far. Let's see the build results when the PR gets approved by the D2H coordinators.

zhangbiao-phy
zhangbiao-phy previously approved these changes Sep 17, 2026

@zhangbiao-phy zhangbiao-phy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @laszlogyulai, Thanks! Looks good to me!

@zhangbiao-phy
zhangbiao-phy enabled auto-merge (squash) September 17, 2026 08:42
@alibuild

alibuild commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for 6629a3a at 2026-09-21 05:56:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:408:36: error: 'const struct o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Join<o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >' has no member named 'isInelGt0'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

alibuild commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for 6629a3a at 2026-09-21 07:49:

## sw/BUILD/VecGeom-latest/log
CMake Error at /container/bits/sw/BUILD/4b902089e8ae3e1235b16cffffe5b41003a490dd/VecGeom/buildExternals/VecCore-0.8.0/build/external/stamp/VecCore-0.8.0-configure-RELWITHDEBINFO.cmake:49 (message):
ninja: build stopped: subcommand failed.
CMake Error at cmake/modules/BuiltinVecCore.cmake:36 (add_custom_command):
CMake Error at CMakeLists.txt:222 (find_package):

Full log here.

@alibuild

alibuild commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for 6629a3a at 2026-09-21 08:09:

## sw/BUILD/O2-latest/log
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:75:56
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:83:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:84:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/Upgrades/ALICE3/ECal/base/src/ECalBaseLinkDef.h:19:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/Upgrades/ALICE3/RICH/base/src/RICHBaseLinkDef.h:18:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/Upgrades/ALICE3/MID/base/src/MI3BaseLinkDef.h:18:47


## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:127:25: error: unused variable 'doprocess' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:560:20: error: unused variable 'chi2PCA' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:482:19: error: unused variable 'flatCalibrated' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:469:39: error: unused parameter 'bcs' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:470:42: error: unused parameter 'tracks' [-Werror=unused-parameter]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:642:19: error: unused variable 'flatCalibrated' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:740:17: error: unused variable 'minItsClustersOfProngs' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:741:17: error: unused variable 'minTpcCrossedRowsOfProngs' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:873:22: error: unused variable 'ptProng0' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:874:22: error: unused variable 'ptProng1' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:875:22: error: unused variable 'ptProng2' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:876:22: error: unused variable 'decayLength' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:877:22: error: unused variable 'chi2PCA' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:878:22: error: unused variable 'cpa' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:855:19: error: unused variable 'flatCalibrated' [-Werror=unused-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:408:36: error: 'const struct o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Join<o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >' has no member named 'isInelGt0'
ninja: build stopped: subcommand failed.

Full log here.

Please consider the following formatting changes to AliceO2Group#17808
@laszlogyulai

Copy link
Copy Markdown
Author

Hi @zhangbiao-phy , could you check if the corrections are fine?

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/staging for c8d2457 at 2026-09-21 14:55:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:643:12: error: variable 'trackNeg' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:408:36: error: 'const struct o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Join<o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >' has no member named 'isInelGt0'
ninja: build stopped: subcommand failed.

Full log here.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/code-check for c8d2457 at 2026-09-21 14:55:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:408:36: error: 'const struct o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Join<o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >' has no member named 'isInelGt0'
ninja: build stopped: subcommand failed.

Full log here.

@vkucera
vkucera marked this pull request as draft September 21, 2026 13:29
@vkucera

vkucera commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

@laszlogyulai Please first compile and test your changes locally before updating the PR.

@laszlogyulai

Copy link
Copy Markdown
Author

@laszlogyulai Please first compile and test your changes locally before updating the PR.

Sure thing. The current (and previous) versions of the code compile and run smoothly on my local machine. Therefore, I am trying to solve the errors by looking at the output logs here.

@vkucera

vkucera commented Sep 21, 2026

Copy link
Copy Markdown
Collaborator

@laszlogyulai Please first compile and test your changes locally before updating the PR.

Sure thing. The current (and previous) versions of the code compile and run smoothly on my local machine. Therefore, I am trying to solve the errors by looking at the output logs here.

That's not the right approach. Your branch is obsolete. You should instead update it and re-test everything with the latest O2Physics.

@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2Physics/o2 for c8d2457 at 2026-09-21 17:33:

## sw/BUILD/O2-latest/log
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:75:56
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:83:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/TPC/base/src/TPCBaseLinkDef.h:84:135
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/Upgrades/ALICE3/ECal/base/src/ECalBaseLinkDef.h:19:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/Upgrades/ALICE3/RICH/base/src/RICHBaseLinkDef.h:18:48
Error: missing ; at end of rule at /sw/SOURCES/O2/daily-20260921-0000/daily-20260921-0000/Detectors/Upgrades/ALICE3/MID/base/src/MI3BaseLinkDef.h:18:47


## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/D2H/Tasks/taskFlattenicityD0Lc.cxx:643:12: error: variable 'trackNeg' set but not used [-Werror=unused-but-set-variable]
/sw/SOURCES/O2Physics/slc10_x86-64-slc10_x86-64/0/PWGHF/Utils/utilsEvSelHf.h:408:36: error: 'const struct o2::soa::Table<o2::aod::Hash<519320931>, o2::aod::Hash<1837103245>, o2::aod::Hash<519320931>, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >::TableIteratorBase<o2::soa::DefaultIndexPolicy, o2::soa::Join<o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >, o2::soa::Table<o2::aod::Hash<1373761118>, o2::aod::Hash<4191360419>, o2::aod::Hash<2286545062> >, o2::soa::Table<o2::aod::Hash<254116537>, o2::aod::Hash<3484684091>, o2::aod::Hash<2286545062> > >' has no member named 'isInelGt0'
ninja: build stopped: subcommand failed.

Full log here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pwghf PWG-HF

Development

Successfully merging this pull request may close these issues.

4 participants