Skip to content

[MUON] fix computation of delta phi in MFT-MCH matching - #15796

Merged
shahor02 merged 1 commit into
AliceO2Group:devfrom
aferrero2707:muon-mft-matching-fix-dphi-computation
Sep 21, 2026
Merged

shahor02 merged 1 commit into
AliceO2Group:devfrom
aferrero2707:muon-mft-matching-fix-dphi-computation

Conversation

@aferrero2707

Copy link
Copy Markdown
Collaborator

The value of delta phi between the MFT and MCH tracks at the matching plane is restricted to the [-pi, pi] range, to fix the cases of large angular differences when the MFT and MCH tracks are at the opposite side of the horizontal plane at negative X values.

Comment thread Detectors/GlobalTracking/src/MatchGlobalFwd.cxx Outdated
@alibuild

alibuild commented Sep 15, 2026

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for 678aac3 at 2026-09-21 15:02:

## sw/BUILD/O2-latest/log
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/TPC/base/src/TPCBaseLinkDef.h:75:56
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/TPC/base/src/TPCBaseLinkDef.h:83:135
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/TPC/base/src/TPCBaseLinkDef.h:84:135
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/ECal/base/src/ECalBaseLinkDef.h:19:48
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/RICH/base/src/RICHBaseLinkDef.h:18:48
Error: missing ; at end of rule at /sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/Upgrades/ALICE3/MID/base/src/MI3BaseLinkDef.h:18:47


## sw/BUILD/o2checkcode-latest/log
--
========== List of errors found ==========
++ GRERR=0
++ grep -v clang-diagnostic-error error-log.txt
++ grep ' error:'
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/GlobalTracking/src/MatchGlobalFwd.cxx:898:43: error: statement should be inside braces [readability-braces-around-statements]
/sw/SOURCES/O2/slc9_x86-64-slc9_x86-64/0/Detectors/GlobalTracking/src/MatchGlobalFwd.cxx:899:43: error: statement should be inside braces [readability-braces-around-statements]
++ [[ 0 == 0 ]]
++ exit 1
--

Full log here.

The value of delta phi between the MFT and MCH tracks
at the matching plane is restricted to the [-pi, pi]
range, to fix the cases of large angular differences
when the MFT and MCH tracks are at the opposite side
of the horizontal plane at negative X values.
@aferrero2707
aferrero2707 force-pushed the muon-mft-matching-fix-dphi-computation branch from 5b29fb4 to aa7ad8b Compare September 21, 2026 15:45
@alibuild

Copy link
Copy Markdown
Collaborator

Error while checking build/O2/fullCI_slc9 for aa7ad8b at 2026-09-21 18:42:

No log files found

Full log here.

@aferrero2707

Copy link
Copy Markdown
Collaborator Author

@f3sch @shahor02 the CI is failing for unrelated errors... do you know if the jobs will be resubmitted automatically, or if I have to retrigger them with a dummy commit? Is there a global issue with the CI at the moment?
Thanks!

@shahor02

Copy link
Copy Markdown
Collaborator

Failed CIs even did not start. Merging, since the change is trivial.

@shahor02
shahor02 merged commit 06496ea into AliceO2Group:dev Sep 21, 2026
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants