Integration of monopoles in O2 framework - #15602
Open
jackal1-66 wants to merge 8 commits into
Open
jackal1-66 wants to merge 8 commits into
jackal1-66 wants to merge 8 commits into
Conversation
jackal1-66
added a commit
to jackal1-66/AliceO2
that referenced
this pull request
Jul 15, 2026
Please consider the following formatting changes to AliceO2Group#15602
jackal1-66
added a commit
to jackal1-66/AliceO2
that referenced
this pull request
Jul 21, 2026
Please consider the following formatting changes to AliceO2Group#15602
Contributor
|
This PR did not have any update in the last 30 days. Is it still needed? Unless further action in will be closed in 5 days. |
jackal1-66
marked this pull request as ready for review
September 11, 2026 09:15
jackal1-66
requested review from
a team,
davidrohr,
f3sch,
fprino,
mconcas,
mcoquet642,
sawenzel,
shahor02 and
wiechula
as code owners
September 11, 2026 09:15
Collaborator
|
Dear @jackal1-66 , I just merged another PR that touches the TPC Detector code. I seems that this brought in a conflict. Please have a look. |
Collaborator
Author
|
Ciao @wiechula, could you please check that my solution works well for you? I gave priority to your condition over isMonopole. |
Collaborator
Previous version was configuring O2MonopolePhysics globally which replaced the chord finder on the run G4FieldManager and also called G4Transportation::EnableMa gneticMoment(true), which are botbh global switched. Since NystromRK4 is incompatible with the monopole physics, the G4ClassicalRK4 was used, which I think is wrong, as I wanted to keep the original stepper the VMC macro asks for. Now the monopoles chord finder is built and not installed. In addition some minor things that were raised by Sandro's review and found while rechecking the code: - Now SetMaxstep(1.e10) is not called for monopoles, as that limit belongs to the dri ft volume rather than the track - TPC and ITS ProcessHits look up the monopole PDG code for neutral tracks only (reduction in calls) - Throw fatal in case Monopole Physics is requested but not installed properly The commit, together with the rest has been validated by running with Schwinger pair monopoles + various gD options.
Collaborator
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the monopoles integration in AliceO2