chat: the unconnected custom row on /connect keeps its vendored name - #1195
Merged
Merged
Conversation
modelConnectionStatus renamed every custom-id row to the connection's Written word, and the catalog template's Written is the bare id, so a person who had connected nothing yet saw `custom` where the manual, the README and #1107 all say `Custom OpenAI-compatible API`. Only a connected instance is called what the person called it now. The contract test draws both rows — the unconnected template and a connected instance named alpha — and is red on the tree without the fix. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What a person saw
Open
/connecton a profile with no custom connection yet. The row that adds one readsThe manual (
services.md,commands.md), the README and #1107 all send them looking for Custom OpenAI-compatible API. Found while verifying the staging build of #1194 (lane frameD4-connect-rows, reproduced on a freshCODEAF_HOME).Why
modelConnectionStatusininternal/tui3/modelservices.gorenames every custom-id row to the connection'sWrittenword so that a connected instance is called what the person called it. The catalog template'sWrittenis the bare idcustom, so the rename also hit the unconnected row. Came in with #1194 (the line is new since v0.2.1).What changed
Only a connected instance (
held) takes itsWrittenname; the unconnected template keeps its vendored name. The contract testTestTheUnconnectedCustomRowKeepsItsVendoredNameAndAConnectedOneTakesThePersonsdraws both rows and is red on the tree without the fix:Validation contract
/connectrow and its Providers twin readCustom OpenAI-compatible API.alphareadsalphaon the same rows.Something elseappears nowhere.🤖 Generated with Claude Code