From 164055682cc96d22e0c48eee4e6b38bfc4362ff3 Mon Sep 17 00:00:00 2001
From: Bill Leoutsakos <billleoutsakos@Bills-MacBook-Pro.local>
Date: Tue, 22 Sep 2026 13:15:59 -0700
Subject: [PATCH] improvement(ui): share knowledge filter headings

---
 .../knowledge/components/index.ts             |  1 +
 .../components/knowledge-filter-heading.tsx   | 26 +++++++++
 .../knowledge/knowledge.test.tsx              |  3 +-
 .../[workspaceId]/knowledge/knowledge.tsx     | 55 ++++++-------------
 4 files changed, 46 insertions(+), 39 deletions(-)
 create mode 100644 apps/sim/app/workspace/[workspaceId]/knowledge/components/knowledge-filter-heading.tsx

diff --git a/apps/sim/app/workspace/[workspaceId]/knowledge/components/index.ts b/apps/sim/app/workspace/[workspaceId]/knowledge/components/index.ts
index f8a396f34b0..32d4f68c0d8 100644
--- a/apps/sim/app/workspace/[workspaceId]/knowledge/components/index.ts
+++ b/apps/sim/app/workspace/[workspaceId]/knowledge/components/index.ts
@@ -1,3 +1,4 @@
+export { KnowledgeFilterHeading } from '@/app/workspace/[workspaceId]/knowledge/components/knowledge-filter-heading'
 export { CreateBaseModal } from './create-base-modal'
 export { DeleteKnowledgeBaseModal } from './delete-knowledge-base-modal'
 export { EditKnowledgeBaseModal } from './edit-knowledge-base-modal'
diff --git a/apps/sim/app/workspace/[workspaceId]/knowledge/components/knowledge-filter-heading.tsx b/apps/sim/app/workspace/[workspaceId]/knowledge/components/knowledge-filter-heading.tsx
new file mode 100644
index 00000000000..4f957908e4f
--- /dev/null
+++ b/apps/sim/app/workspace/[workspaceId]/knowledge/components/knowledge-filter-heading.tsx
@@ -0,0 +1,26 @@
+import { Button } from '@sim/emcn'
+import { FILTER_SECTION_LABEL_CLASS } from '@/app/workspace/[workspaceId]/components'
+
+interface KnowledgeFilterHeadingProps {
+  title: string
+  active: boolean
+  onClear: () => void
+}
+
+/** Heading and conditional clear action for a knowledge-list filter. */
+export function KnowledgeFilterHeading({ title, active, onClear }: KnowledgeFilterHeadingProps) {
+  return (
+    <div className='flex h-5 items-center justify-between'>
+      <span className={FILTER_SECTION_LABEL_CLASS}>{title}</span>
+      {active && (
+        <Button
+          variant='ghost'
+          onClick={onClear}
+          className='-mr-1 h-auto px-1 py-0.5 text-[var(--text-muted)] text-xs hover-hover:text-[var(--text-secondary)]'
+        >
+          Clear
+        </Button>
+      )}
+    </div>
+  )
+}
diff --git a/apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.test.tsx b/apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.test.tsx
index a03d3348d72..ab97f699aa9 100644
--- a/apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.test.tsx
+++ b/apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.test.tsx
@@ -96,7 +96,8 @@ vi.mock('@/connectors/registry', () => ({ CONNECTOR_META_REGISTRY: {} }))
 vi.mock('@/app/workspace/[workspaceId]/knowledge/[id]/components/base-tags-modal', () => ({
   BaseTagsModal: () => null,
 }))
-vi.mock('@/app/workspace/[workspaceId]/knowledge/components', () => ({
+vi.mock('@/app/workspace/[workspaceId]/knowledge/components', async () => ({
+  ...(await import('@/app/workspace/[workspaceId]/knowledge/components/knowledge-filter-heading')),
   CreateBaseModal: () => null,
   EditKnowledgeBaseModal: () => null,
   KnowledgeListContextMenu: () => null,
diff --git a/apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx b/apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx
index 994b3d820d9..3d813532aca 100644
--- a/apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx
+++ b/apps/sim/app/workspace/[workspaceId]/knowledge/knowledge.tsx
@@ -2,7 +2,7 @@
 
 import { useCallback, useEffect, useMemo, useRef, useState } from 'react'
 import type { ChipSelectOption } from '@sim/emcn'
-import { Button, ChipConfirmModal, ChipSelect, Tooltip, toast } from '@sim/emcn'
+import { ChipConfirmModal, ChipSelect, Tooltip, toast } from '@sim/emcn'
 import { Database, FolderPlus, Pencil, Plus, Trash } from '@sim/emcn/icons'
 import { createLogger } from '@sim/logger'
 import { getErrorMessage } from '@sim/utils/errors'
@@ -23,7 +23,6 @@ import type {
 } from '@/app/workspace/[workspaceId]/components'
 import {
   EMPTY_CELL_PLACEHOLDER,
-  FILTER_SECTION_LABEL_CLASS,
   OwnerAvatar,
   ownerCell,
   Resource,
@@ -70,6 +69,7 @@ import {
   DeleteKnowledgeBaseModal,
   EditKnowledgeBaseModal,
   KnowledgeBaseContextMenu,
+  KnowledgeFilterHeading,
   KnowledgeListContextMenu,
 } from '@/app/workspace/[workspaceId]/knowledge/components'
 import KnowledgeLoading from '@/app/workspace/[workspaceId]/knowledge/loading'
@@ -1334,18 +1334,11 @@ function KnowledgeContent() {
     () => (
       <div className='flex w-[260px] flex-col gap-3 p-3'>
         <div className='flex flex-col gap-2'>
-          <div className='flex h-5 items-center justify-between'>
-            <span className={FILTER_SECTION_LABEL_CLASS}>Connectors</span>
-            {connectorFilter.length > 0 && (
-              <Button
-                variant='ghost'
-                onClick={() => setConnectorFilter([])}
-                className='-mr-1 h-auto px-1 py-0.5 text-[var(--text-muted)] text-xs hover-hover:text-[var(--text-secondary)]'
-              >
-                Clear
-              </Button>
-            )}
-          </div>
+          <KnowledgeFilterHeading
+            title='Connectors'
+            active={connectorFilter.length > 0}
+            onClear={() => setConnectorFilter([])}
+          />
           <ChipSelect
             showSelectedCheck
             dropdownWidth='trigger'
@@ -1358,18 +1351,11 @@ function KnowledgeContent() {
           />
         </div>
         <div className='flex flex-col gap-2'>
-          <div className='flex h-5 items-center justify-between'>
-            <span className={FILTER_SECTION_LABEL_CLASS}>Content</span>
-            {contentFilter.length > 0 && (
-              <Button
-                variant='ghost'
-                onClick={() => setContentFilter([])}
-                className='-mr-1 h-auto px-1 py-0.5 text-[var(--text-muted)] text-xs hover-hover:text-[var(--text-secondary)]'
-              >
-                Clear
-              </Button>
-            )}
-          </div>
+          <KnowledgeFilterHeading
+            title='Content'
+            active={contentFilter.length > 0}
+            onClear={() => setContentFilter([])}
+          />
           <ChipSelect
             showSelectedCheck
             dropdownWidth='trigger'
@@ -1383,18 +1369,11 @@ function KnowledgeContent() {
         </div>
         {memberOptions.length > 0 && (
           <div className='flex flex-col gap-2'>
-            <div className='flex h-5 items-center justify-between'>
-              <span className={FILTER_SECTION_LABEL_CLASS}>Owner</span>
-              {ownerFilter.length > 0 && (
-                <Button
-                  variant='ghost'
-                  onClick={() => setOwnerFilter([])}
-                  className='-mr-1 h-auto px-1 py-0.5 text-[var(--text-muted)] text-xs hover-hover:text-[var(--text-secondary)]'
-                >
-                  Clear
-                </Button>
-              )}
-            </div>
+            <KnowledgeFilterHeading
+              title='Owner'
+              active={ownerFilter.length > 0}
+              onClear={() => setOwnerFilter([])}
+            />
             <ChipSelect
               placeholder='All'
               showAllOption