From e86a90c74f8c8c1448907f9f6393a57c5c4ba796 Mon Sep 17 00:00:00 2001 From: Ya-Fan Chen <20377719+Lexachoc@users.noreply.github.com> Date: Mon, 21 Sep 2026 14:26:41 +0200 Subject: [PATCH 1/4] fix unresolved lib methods --- src/lib/index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib/index.js b/src/lib/index.js index 7c0d136e026..fedba04f9a0 100644 --- a/src/lib/index.js +++ b/src/lib/index.js @@ -10,7 +10,8 @@ var MAX_SAFE = numConstants.FP_SAFE; var MIN_SAFE = -MAX_SAFE; var BADNUM = numConstants.BADNUM; -var lib = (module.exports = {}); +module.exports = {}; +var lib = module.exports; lib.adjustFormat = function adjustFormat(formatStr) { if (!formatStr || /^\d[.]\df/.test(formatStr) || /[.]\d%/.test(formatStr)) return formatStr; From c4aa4ecdb11421c54768f8452ca8673525084017 Mon Sep 17 00:00:00 2001 From: Ya-Fan Chen <20377719+Lexachoc@users.noreply.github.com> Date: Mon, 21 Sep 2026 16:46:37 +0200 Subject: [PATCH 2/4] fix unresolved drawing methods Refactor module exports in drawing component --- src/components/drawing/index.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/drawing/index.js b/src/components/drawing/index.js index 3a71319c838..782e3646156 100644 --- a/src/components/drawing/index.js +++ b/src/components/drawing/index.js @@ -20,7 +20,8 @@ var subTypes = require('../../traces/scatter/subtypes'); var makeBubbleSizeFn = require('../../traces/scatter/make_bubble_size_func'); var appendArrayPointValue = require('../../components/fx/helpers').appendArrayPointValue; -var drawing = (module.exports = {}); +module.exports = {}; +var drawing = module.exports; // ----------------------------------------------------- // styling functions for plot elements From 7cc4ca19d18595fb5906e928ff7946b6b2ca424f Mon Sep 17 00:00:00 2001 From: Ya-Fan Chen <20377719+Lexachoc@users.noreply.github.com> Date: Tue, 22 Sep 2026 14:39:41 +0200 Subject: [PATCH 3/4] Apply batched suggestions from code review Co-authored-by: Cameron DeCoster --- src/components/drawing/index.js | 4 ++-- src/lib/index.js | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/components/drawing/index.js b/src/components/drawing/index.js index 782e3646156..707c7b2cfb6 100644 --- a/src/components/drawing/index.js +++ b/src/components/drawing/index.js @@ -20,8 +20,8 @@ var subTypes = require('../../traces/scatter/subtypes'); var makeBubbleSizeFn = require('../../traces/scatter/make_bubble_size_func'); var appendArrayPointValue = require('../../components/fx/helpers').appendArrayPointValue; -module.exports = {}; -var drawing = module.exports; +var drawing = {}; +module.exports = drawing; // ----------------------------------------------------- // styling functions for plot elements diff --git a/src/lib/index.js b/src/lib/index.js index fedba04f9a0..22788501228 100644 --- a/src/lib/index.js +++ b/src/lib/index.js @@ -10,8 +10,8 @@ var MAX_SAFE = numConstants.FP_SAFE; var MIN_SAFE = -MAX_SAFE; var BADNUM = numConstants.BADNUM; -module.exports = {}; -var lib = module.exports; +var lib = {}; +module.exports = lib; lib.adjustFormat = function adjustFormat(formatStr) { if (!formatStr || /^\d[.]\df/.test(formatStr) || /[.]\d%/.test(formatStr)) return formatStr; From a78ea529c59c6906cbf1acc211dba868edbfd847 Mon Sep 17 00:00:00 2001 From: Ya-Fan Chen <20377719+Lexachoc@users.noreply.github.com> Date: Tue, 22 Sep 2026 14:43:13 +0200 Subject: [PATCH 4/4] Refactor modeBarButtons export syntax --- src/components/modebar/buttons.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/components/modebar/buttons.js b/src/components/modebar/buttons.js index 33b5d5f66d3..7914bc1c793 100644 --- a/src/components/modebar/buttons.js +++ b/src/components/modebar/buttons.js @@ -9,7 +9,8 @@ var confirmCloudDialog = require('./share_chart/dialog'); var Lib = require('../../lib'); var _ = Lib._; -var modeBarButtons = (module.exports = {}); +var modeBarButtons = {}; +module.exports = modeBarButtons; /** * ModeBar buttons configuration