From f001b5c1815e5e073573c806a3bba6dd1e178292 Mon Sep 17 00:00:00 2001 From: Tadeja Kadunc Date: Thu, 24 Sep 2026 17:45:43 +0200 Subject: [PATCH 1/3] Initial commit --- ci/scripts/python_build_emscripten.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/ci/scripts/python_build_emscripten.sh b/ci/scripts/python_build_emscripten.sh index 061e7df7593..759c1c13230 100755 --- a/ci/scripts/python_build_emscripten.sh +++ b/ci/scripts/python_build_emscripten.sh @@ -44,5 +44,7 @@ if [ "${GITHUB_ACTIONS:-}" = "true" ]; then fi pushd "${python_build_dir}" +# For LLVM 23 llvm-strip to not remove required dylink.0 +export SKBUILD_INSTALL_STRIP=false pyodide build popd From 0a82573d9be20571b9874bcdc0e4e2a278f41460 Mon Sep 17 00:00:00 2001 From: tadeja Date: Wed, 30 Sep 2026 11:35:50 +0200 Subject: [PATCH 2/3] Update ci/scripts/python_build_emscripten.sh MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Co-authored-by: Raúl Cumplido --- ci/scripts/python_build_emscripten.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ci/scripts/python_build_emscripten.sh b/ci/scripts/python_build_emscripten.sh index 759c1c13230..6e48380f9ed 100755 --- a/ci/scripts/python_build_emscripten.sh +++ b/ci/scripts/python_build_emscripten.sh @@ -44,7 +44,8 @@ if [ "${GITHUB_ACTIONS:-}" = "true" ]; then fi pushd "${python_build_dir}" -# For LLVM 23 llvm-strip to not remove required dylink.0 +# scikit-build-core strips unnecessary symbols by default. +# Avoid LLVM 23 llvm-strip to strip the required dylink.0 export SKBUILD_INSTALL_STRIP=false pyodide build popd From d1a748fc9c61e450b3660c0a2a398af3b3111313 Mon Sep 17 00:00:00 2001 From: tadeja Date: Wed, 30 Sep 2026 11:45:34 +0200 Subject: [PATCH 3/3] Update code remaining code comment --- ci/scripts/python_build_emscripten.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ci/scripts/python_build_emscripten.sh b/ci/scripts/python_build_emscripten.sh index 6e48380f9ed..a0c97b8c2cd 100755 --- a/ci/scripts/python_build_emscripten.sh +++ b/ci/scripts/python_build_emscripten.sh @@ -45,7 +45,7 @@ fi pushd "${python_build_dir}" # scikit-build-core strips unnecessary symbols by default. -# Avoid LLVM 23 llvm-strip to strip the required dylink.0 +# LLVM 23 also removes the required dylink.0 section (llvm/llvm-project#180246) export SKBUILD_INSTALL_STRIP=false pyodide build popd