Skip to content

Commit 3969597

Browse files
committed
Fixed review changes
1 parent 06185f9 commit 3969597

2 files changed

Lines changed: 31 additions & 16 deletions

File tree

‎Form-Controls/index.html‎

Lines changed: 20 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@ <h1>Product Pick</h1>
1616
</header>
1717

1818
<main>
19-
<form action="results.html" method="GET">
19+
2020
<div>
2121
<label for="name">Name</label>
2222
<input
2323
type="text"
24-
name="Name"
24+
name="name"
2525
id="name"
2626
placeholder="Username"
2727
autocomplete="name"
@@ -35,14 +35,17 @@ <h1>Product Pick</h1>
3535
<label for="email">Email</label>
3636
<input
3737
type="email"
38-
name="Email"
38+
name="email"
3939
id="email"
4040
placeholder="Email"
4141
required
4242
/>
4343
</div>
4444

45-
T-shirt Color
45+
46+
47+
<legend>T-shirt Color</legend>
48+
4649

4750
<div>
4851
<label for="red">Red</label>
@@ -75,18 +78,19 @@ <h1>Product Pick</h1>
7578
/>
7679
</div>
7780

78-
<div>
79-
<label for="size">T-shirt Size</label>
80-
<select name="T-shirt Size" id="size" required>
81-
<option label="Select a size" value=""></option>
82-
<option label="XS" value="XS"></option>
83-
<option label="S" value="S"></option>
84-
<option label="M" value="M"></option>
85-
<option label="L" value="L"></option>
86-
<option label="XL" value="XL"></option>
87-
<option label="XXL" value="XXL"></option>
88-
</select>
89-
</div>
81+
<div>
82+
<label for="size">T-shirt Size</label>
83+
<select name="T-shirt-size" id="size" required>
84+
<option value="">Select a size</option>
85+
<option value="XS">XS</option>
86+
<option value="S">S</option>
87+
<option value="M">M</option>
88+
<option value="L">L</option>
89+
<option value="XL">XL</option>
90+
<option value="XXL">XXL</option>
91+
</select>
92+
</div>
93+
9094

9195
<div>
9296
<button type="reset">Reset</button>

‎Form-Controls/style.css‎

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
1+
2+
button,
3+
select {
4+
min-height: 44px;
5+
padding: 8px 12px;
6+
}
7+
8+
button {
9+
margin-right: 8px;
10+
}
11+

0 commit comments

Comments
 (0)